Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update primitive mutable states to mutableState API where applicable #972

Merged
merged 4 commits into from
Oct 14, 2023

Conversation

tjmtic
Copy link
Contributor

@tjmtic tjmtic commented Oct 4, 2023

Fixes #888

It looks like a few states were based on Int or Float, which are converted here. The rest it seems are either an object value or a boolean, and from the 1.5.0 commit:

We are not adding BooleanState here because the autoboxing penalty for
Boolean types is virtually nonexistent because the JVM manages a pool
of the boxed versions of true and false, meaning that the boxing
operation will never cause an allocation.

https://android-review.googlesource.com/c/platform/frameworks/support/+/2375802

So I think that covers them, but happy to make any other update.

@tjmtic tjmtic changed the title Update compose-runtime version; Update primitive mutable states to mu… Update primitive mutable states to mutableState API where applicable Oct 10, 2023
@tunjid tunjid merged commit 78573b8 into android:main Oct 14, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR]: Use primitive mutable states where appropriate.
3 participants